User talk:Alexis Jazz/LuckyRename

Testing notes

• File:Ambox important.svg is a fully protected file that LuckyRename soon shouldn't allow editing without warning. — Alexis Jazz (talk or ping me) 07:51, 22 July 2021 (UTC)

Edit comment

Hello!

This is one of your edit comments: Alexis Jazz moved page File:CS Sportul Snagov (association football club) logo.png to File:CSM Metalul Resita (association football club) logo.png: Renamed File:CS Sportul Snagov (association football club) logo.png to File:CSM Metalul Resita (association football club) logo.png: Obvious error my mistake (LuckyRename). I find this quite repetitive, maybe Obvious error my mistake is enough?Jonteemil (talk) 17:43, 26 July 2021 (UTC)

Jonteemil, that's the full log entry. But I see your point, the edit summary repeats the log entry. I'll look at it. — Alexis Jazz (talk or ping me) 05:07, 27 July 2021 (UTC)

Jonteemil, that was actually a bug. Don't tell anyone. When updating a file description page (replacing links to itself) without removing a {{Rename media}} template, the edit summary was supposed to be adjusted so it wouldn't say "removing template" as removing the template and replacing usage is done in the same edit for the file page. But instead of adjusting the edit summary for the file page update, it adjusted the move summary. — Alexis Jazz (talk or ping me) 10:44, 27 July 2021 (UTC)

Okay, I see. I'll keep quiet.Jonteemil (talk) 13:14, 2 August 2021 (UTC)

Script error?

EpicPupper, what script error did you encounter? — Alexis Jazz (talk or ping me) 09:41, 15 August 2021 (UTC)

I removed some bugs, hopefully whatever you encountered is fixed now too. — Alexis Jazz (talk or ping me) 11:07, 15 August 2021 (UTC)

@Alexis Jazz Hi there, the script didn't seem to save, and some JS errors popped up (forgot what they were unfortunately) so I clicked the button to save twice. (Technically partially human error). Wonderful to hear that some bugs are fixed! 🐶 EpicPupper ^{(he/him | talk, FAQ, contribs)} 04:24, 16 August 2021 (UTC)

EpicPupper, yes, I recently improved the progress indicator when moving files. This part isn't loaded when requesting renames but it still tried to update the progress indicator (which wasn't loaded) after editing the file page. This causes an error, makes the script stop and you'd see no confirmation that your request was successful. This should work better now. Error handling is missing for requests atm (will fix soon) but this rarely causes any trouble. In addition the script now removes any existing requests before adding a new one so requests can't pile up. In a diff this typically looks like the request is just getting adjusted. Example. Please report any errors, misbehavior, or feature requests you have. Testing every possible thing that might happen is impossible so such reports are invaluable. — Alexis Jazz (talk or ping me) 05:04, 16 August 2021 (UTC)

Awesome, thanks! Will do. 🐶 EpicPupper ^{(he/him | talk, FAQ, contribs)} 06:08, 16 August 2021 (UTC)

Hi @Alexis Jazz: I recently encountered this error :) [1] 🐶 EpicPupper ^{(he/him | talk, FAQ, contribs)} 06:18, 16 August 2021 (UTC)

EpicPupper, where did you see this error? What where you doing when it happened? Is it reproducible? — Alexis Jazz (talk or ping me) 10:44, 16 August 2021 (UTC)

Exemptions

Might want to consider exempting Wikipedia:Database reports/Non-free files shadowing a Commons file from the tool, as it's not necessary to change filenames there. Jo-Jo Eumerus (talk) 18:27, 23 August 2021 (UTC)

Jo-Jo Eumerus, I'd rather not include any hardcoded blacklist. And since it's a bot page that is still getting updated, either of us adding {{bots|deny=luckyrename}} would likely be reverted by the bot on the next update. Fastily, it does seem replacements are pointless here so you could add it? Also, why is that a list and aren't the files tagged with {{ShadowsCommons}}? I watch the maintenance category, how am I supposed to know about the list? — Alexis Jazz (talk or ping me) 08:00, 24 August 2021 (UTC)

May I suggest having your tool skip pages in the Wikipedia and User namespaces? Generally speaking, this isn't a welcome change for users who keep/maintain lists. -FASTILY 10:29, 24 August 2021 (UTC)

Fastily, this would likely be problematic for drafts in userspace, main user pages (like User:Fastily) and userboxes. For Wikipedia: it would be problematic for village pumps, essays, FfD archives, featured article discussion, etc. If those lists would self-identify as automatically generated lists in a unified way, I could avoid them. Skipping whole namespaces is too crude. — Alexis Jazz (talk or ping me) 10:46, 24 August 2021 (UTC)

Have you considered modifying the UI to offer the user a list of checkboxes to select specific pages to update links, post-page move? -FASTILY 20:53, 24 August 2021 (UTC)

Fastily, I don't like that idea. I wanted to keep the tool as simple as possible, KISS. Users shouldn't be bothered with having to determine which pages are bot-generated. I created {{Automatically generated}} for users who keep/maintain lists. This will be respected by LuckyRename after the next update. (currently in User:Alexis Jazz/LuckyRename-test.js) It's preferable for users who create such lists to have to determine once that they are creating such a list rather than forcing file movers to go over a bunch of checkboxes for every single move. If a list creator is unaware of this or decides not to bother, no problem. LuckyRename will replace the usage on their lists. It's no problem for LuckyRename. — Alexis Jazz (talk or ping me) 18:31, 26 August 2021 (UTC)

I respectfully disagree. I don't think it should be the responsibility of the list/report creator to actively fend off unwanted changes to their pages. This just seems like a common courtesy. -FASTILY 22:00, 26 August 2021 (UTC)

Fastily, we can agree to disagree of course. The required effort for list creators is very tiny and will improve the quality of their pages as they can now be identified and categorized. Otherwise file movers would be forced to go over a bunch of checkboxes every single time they move a file. The "burden" is far less for the list creators. — Alexis Jazz (talk or ping me) 00:18, 27 August 2021 (UTC)

Suggestion

Hello, when moving a file and not leaving a redirect, would it be possible in the summary to just list it as "Renamed [[File:Example|Old file]] to [[File:NewExample]]..." otherwise the summary can end up leaving a large redlink. Terasail^[✉️] 19:34, 2 April 2022 (UTC)

Forgot ping: @Alexis Jazz. Terasail^[✉️] 19:35, 2 April 2022 (UTC)

Terasail, if I could I would, but the "moved page (original name) to (new name) without leaving a redirect" part is inserted by the MediaWiki software, I have no control over it. You could file a task on Phabricator but I'm not sure how they could implement this. Maybe by clipping the old name and adding "..." or something, but I'm not sure they'd even consider it and such tasks tend to get very low priority. (what I'm saying is, curb your expectations) But if you want it, that's the way to go I guess. — Alexis Jazz (talk or ping me) 01:46, 3 April 2022 (UTC)

No I mean in the edit summaries when editing the pages. Example: Special:Diff/1080682399, at line 645 "var summary =..." this is where the description is set and if the first link was just piped to "old file" then that would reduce the large edit summaries that can occur. Terasail^[✉️] 12:53, 3 April 2022 (UTC)

@Alexis Jazz This was just an idea, I dont plan on attempting to change how pagemoves appear in logs. Just on mainspace pages large edit summaries giving the oldfilename that most people would not be interested in. Terasail^[✉️] 12:58, 3 April 2022 (UTC)

Terasail, now I see. The summaries for the file itself and the replacement in articles are different things. Only the former is affected by not leaving a redirect, so your mention of "not leaving a redirect" made me think that was what you meant. The article replacement summary was based on the summary that c:Commons:File renaming/Global replace generates for replacements. Is it better now? (example) — Alexis Jazz (talk or ping me) 15:13, 3 April 2022 (UTC)

@Alexis Jazz Yeah. Thanks, Terasail^[✉️] 15:24, 3 April 2022 (UTC)

Terasail, you're welcome. :-) And sorry for the initial misunderstanding. — Alexis Jazz (talk or ping me) 16:37, 3 April 2022 (UTC)

Page edit error

@Alexis Jazz Hello, I came across this error when I renamed a file. Special:Diff/1085133506, not sure what happened here but it copied the text above the file as well as incorrectly changing the filename. Terasail^[✉️] 16:30, 28 April 2022 (UTC)

Terasail, I suspect the "$1" in "$100" was interpreted as a regular expression group, that's pretty bad.. I'll fix it. — Alexis Jazz (talk or ping me) 19:31, 28 April 2022 (UTC)

Terasail, I think it works correctly now. The edit summaries still contain errors because the MediaWiki devs seemingly made the same error I did, but this doesn't appear to affect the actual move or replacement. — Alexis Jazz (talk or ping me) 02:39, 29 April 2022 (UTC)

File:Zstandard logo.png problem

File:Zstandard logo.png is not accepting a rename to an "-en" version. Jo-Jo Eumerus (talk) 16:16, 31 October 2022 (UTC)

Same on File:Antoni Zygmund.jpg. Jo-Jo Eumerus (talk) 16:18, 31 October 2022 (UTC)

Jo-Jo Eumerus, these files have already been deleted, I don't know what went wrong. I'm barely active due to personal reasons, I don't look at my watchlist. If you don't ping me, I'm generally unlikely to see your comment. — Alexis Jazz (talk or ping me) 17:36, 25 January 2023 (UTC)

Button does not appear in new skin

Alexis Jazz, noted this when trying to rename File:NTSF SD SUV.png. Jo-Jo Eumerus (talk) 17:02, 25 January 2023 (UTC)

Jo-Jo Eumerus, how about now? — Alexis Jazz (talk or ping me) 17:32, 25 January 2023 (UTC)

Thanks, it looks like it appears now. Didn't test it, though. Jo-Jo Eumerus (talk) 10:34, 26 January 2023 (UTC)

Moving page name affects other spaces

Alexis Jazz, is it possible that moving a file will not affect pages other than the mainspace? Kailash29792 (talk) 08:05, 6 May 2023 (UTC)

Kailash29792, which file did you try to move and which page failed to be updated? — Alexis Jazz (talk or ping me) 15:21, 6 May 2023 (UTC)

When moving File:Jay jay madhavan.jpg to File:Jay Jay poster.jpg, it updated the file name in my talk page (another's message) and this. I undid them though. Kailash29792 (talk) 15:26, 6 May 2023 (UTC)

Kailash29792, such pages should use {{Automatically generated}} or {{bots|deny=luckyrename}}. There have been discussions about this before and my position is that automatically generated lists should identify themselves (using a template) so LuckyRename and other tools can avoid them. The burden shouldn't be on the file mover to go over all uses to find bot pages by hand every time. That would be more work and more error-prone. Btw, the edit to your user page: User talk:Kailash29792 (Diff ~1153398785) was perfectly valid, it fixed a redlink. — Alexis Jazz (talk or ping me) 15:30, 6 May 2023 (UTC)

Glitch on watchlisted pages

@Alexis Jazz: Hello. I am not sure if this is just a me problem, but for some reason, this script does not work if I have a certain file watchlisted. For exaple, if I go to File:Example.jpg, watchlist the page, and reload the page, the clover button disappears and clicking the "Lucky" button does nothing. However, if I unwatch the page and reload, the clover button shows up and the "Lucky" button works as intended. I was able to replicate the glitch on multiple devices. Could you look into this? Thanks in advance. InfiniteNexus (talk) 00:40, 9 May 2023 (UTC)

InfiniteNexus, fixed. If it still doesn't work, hard reload a page or clear your browser cache for the fix to take effect. — Alexis Jazz (talk or ping me) 14:43, 9 May 2023 (UTC)

Yes! It worked. Thanks Alexis. InfiniteNexus (talk) 23:47, 9 May 2023 (UTC)

Rename template requires numerical criterion

Hi @Alexis Jazz, it looks like {{Rename}} requires a numerical criterion as the second parameter, not the link that LuckyRename currently uses. See https://commons.wikimedia.org/w/index.php?title=File:Headshot_(7050694291).jpg&diff=prev&oldid=781519810 for an example of the error. Cheers, Frostly (talk) 20:57, 8 July 2023 (UTC)

(Just to clarify, this is the rename template on Commons). Frostly (talk) 21:12, 8 July 2023 (UTC)

Frostly, you're linking a file on Commons. LuckyRename should not be used on Commons as it doesn't handle global renames when renaming and apparently Commons requires different parameters for the template when requesting renames. Commons already has c:Help:RenameLink enabled by default. Perhaps I'll add a check to prevent LuckyRename from loading on Commons. (which could be useful if you load it using global.js) — Alexis Jazz (talk or ping me) 08:05, 9 July 2023 (UTC)

Thanks for the heads-up! Frostly (talk) 20:00, 9 July 2023 (UTC)