Jump to content

Wikipedia:Bots/Requests for approval/AssumptionBot: Difference between revisions

From Wikipedia, the free encyclopedia
Content deleted Content added
Line 63: Line 63:
*I'm not a BAG member, but I'd like to point out that your code won't work as you expect for multiple reasons. {{pb}} First, Python will interpret <code><nowiki>"{{afc submission".lower()</nowiki></code>, <code><nowiki>"{{articles for creation".lower()</nowiki></code>, etc. as separate conditions that are ''always'' <code>True</code>, meaning the only condition that is actually considered is <code><nowiki>"{{draft article}}".lower() not in page.text</nowiki></code>. {{pb}} Also, your <code>time.sleep</code> call is outside the loop, meaning it will never actually be run. '''[[User:Bsoyka|<span style="color:#0b369b;">Bsoyka</span>]]''' ''([[User talk:Bsoyka|<span style="color:#066b9d;">talk</span>]] &middot; [[Special:Contributions/Bsoyka|<span style="color:#066b9d;">contribs</span>]])'' 04:59, 25 February 2022 (UTC)
*I'm not a BAG member, but I'd like to point out that your code won't work as you expect for multiple reasons. {{pb}} First, Python will interpret <code><nowiki>"{{afc submission".lower()</nowiki></code>, <code><nowiki>"{{articles for creation".lower()</nowiki></code>, etc. as separate conditions that are ''always'' <code>True</code>, meaning the only condition that is actually considered is <code><nowiki>"{{draft article}}".lower() not in page.text</nowiki></code>. {{pb}} Also, your <code>time.sleep</code> call is outside the loop, meaning it will never actually be run. '''[[User:Bsoyka|<span style="color:#0b369b;">Bsoyka</span>]]''' ''([[User talk:Bsoyka|<span style="color:#066b9d;">talk</span>]] &middot; [[Special:Contributions/Bsoyka|<span style="color:#066b9d;">contribs</span>]])'' 04:59, 25 February 2022 (UTC)
*:I'll figure it out when approved. &ndash; <span style="background-color:#414357">[[User:AssumeGoodWraith|<span style="color:Orange">'''AssumeGoodWraith'''</span>]]</span> <small>([[User talk:AssumeGoodWraith|talk]] &#124; [[Special:Contributions/AssumeGoodWraith|contribs]])</small> 05:09, 25 February 2022 (UTC)
*:I'll figure it out when approved. &ndash; <span style="background-color:#414357">[[User:AssumeGoodWraith|<span style="color:Orange">'''AssumeGoodWraith'''</span>]]</span> <small>([[User talk:AssumeGoodWraith|talk]] &#124; [[Special:Contributions/AssumeGoodWraith|contribs]])</small> 05:09, 25 February 2022 (UTC)
*::... Or now. &ndash; <span style="background-color:#414357">[[User:AssumeGoodWraith|<span style="color:Orange">'''AssumeGoodWraith'''</span>]]</span> <small>([[User talk:AssumeGoodWraith|talk]] &#124; [[Special:Contributions/AssumeGoodWraith|contribs]])</small> 05:09, 25 February 2022 (UTC)

Revision as of 05:09, 25 February 2022

New to bots on Wikipedia? Read these primers!

Operator: AssumeGoodWraith (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 11:34, Wednesday, February 16, 2022 (UTC)

Function overview: Adds AFC unsubmitted templates to drafts.

Automatic, Supervised, or Manual: Automatic

Programming language(s): Python

Source code available: I think this works?

Links to relevant discussions (where appropriate): Wikipedia:Village pump (proposals) § Bot proposal (AFC submission templates)

Edit period(s): Meant to be continuous.

Estimated number of pages affected: ~100 a day, judging by the new pages feed (about 250 today) and assuming that not many drafts are left without the afc template

Namespace(s): Draft

Exclusion compliant (Yes/No): Yes (pywikibot)

Function details: Adds AFC unsubmitted templates ( {{afc submission/draft}} ) to drafts in draftspace that don't have them, the {{draft article}} template, or anything that currently redirects to those 2. See the examples in the VPR proposal listed above.

Discussion

  • I'm not going to decline this outright, if only to allow for feedback and other opinions, but not all drafts need to go through AFC, and so having a bot place the template on every draft is extremely problematic. Primefac (talk) 12:22, 16 February 2022 (UTC)[reply]
  •  On hold. until the RFC (which I have fixed the link to) has completed. In the future, get consensus before filing a request. Primefac (talk) 12:22, 16 February 2022 (UTC)[reply]

@Primefac: Not sure if this is a misunderstanding, but it's the unsubmitted template, not the submitted one (Template:afc submission/draft). — Preceding unsigned comment added by AssumeGoodWraith (talkcontribs) 12:28, 16 February 2022 (UTC)[reply]

I know, and my point still stands - not every draft is meant to be sent for review at AFC, and so adding the template to every draft is problematic. Primefac (talk) 12:38, 16 February 2022 (UTC)[reply]
@Primefac: I thought you interpreted the proposal as "automatically submitting all new drafts for review".
I'll wait for the RFC. – AssumeGoodWraith (talk | contribs) 12:49, 16 February 2022 (UTC)[reply]
  • information Note: This bot appears to have edited since this BRFA was filed. Bots may not edit outside their own or their operator's userspace unless approved or approved for trial. AnomieBOT 12:41, 18 February 2022 (UTC)[reply]
  • I'm not a BAG member, but I'd like to point out that your code won't work as you expect for multiple reasons.
    First, Python will interpret "{{afc submission".lower(), "{{articles for creation".lower(), etc. as separate conditions that are always True, meaning the only condition that is actually considered is "{{draft article}}".lower() not in page.text.
    Also, your time.sleep call is outside the loop, meaning it will never actually be run. Bsoyka (talk · contribs) 04:59, 25 February 2022 (UTC)[reply]
    I'll figure it out when approved. – AssumeGoodWraith (talk | contribs) 05:09, 25 February 2022 (UTC)[reply]
    ... Or now. – AssumeGoodWraith (talk | contribs) 05:09, 25 February 2022 (UTC)[reply]